search

python-hyper / h2

HTTP/2 State-Machine based protocol implementation
https://h2.readthedocs.io/en/stable
MIT License
963 stars 151 forks source link

ignore WINDOW_UPDATE frames on removed or non-existent stream #1225

Closed mihau closed 4 years ago

mihau commented 4 years ago

This pull request fixes an issue with receiving WINDOW_UPDATE frames on streams that have been closed and removed - which could happen while opening a new stream.

Please let me know if anything should be done differently. Here are some doubts I have about this approach:

  1. This code will also ignore streams that have never been created. Maybe checking in _closed_streams as well would be better.
  2. Maybe a separate test would make more sense.
szerepak commented 4 years ago

@mihau @Kriechi Any chance of merging this one here?