setup.py fails in environments where locale != *utf8

python-hyper / hpack

HTTP/2 Header Encoding for Python

https://hpack.readthedocs.io/en/latest/

MIT License

72 stars 32 forks source link

Closed sdelafond closed 7 years ago

sdelafond commented 7 years ago

With python3.5, in a "regular" C locale, opening HISTORY.rst fails because that file is utf8-encoded (python2.7 doesn't complain about that).

Lukasa commented 7 years ago

Yup, that seems like a likely problem. Mind supplying a PR to resolve the issue?

sdelafond commented 7 years ago

I was gonna add encoding=utf-8 to the open call, but that won't work in 2.7 unfortunately...

Lukasa commented 7 years ago

@sdelafond You want codecs.open.