search

python-hyper / hpack

HTTP/2 Header Encoding for Python
https://hpack.readthedocs.io/en/latest/
MIT License
72 stars 32 forks source link

Convert HISTORY.rst from UTF-8 format to ASCII #138

Closed yegorich closed 7 years ago

yegorich commented 7 years ago

UTF-8 formatted file breaks installations on some systems:

Traceback (most recent call last): File "setup.py", line 34, in long_description=open('README.rst').read() + '\n\n' + open('HISTORY.rst').read(), File "/home/peko/autobuild/instance-1/output/target/usr/lib/python3.6/encodings/ascii.py", line 26, in decode return codecs.ascii_decode(input, self.errors)[0] UnicodeDecodeError: 'ascii' codec can't decode byte 0xc2 in position 1125: ordinal not in range(128)

To fix this error just replace '§' with 'S' meaning 'Section'.

Lukasa commented 7 years ago

Rather than change the readme, why don't we use codecs.open to open the file? That way we won't run into this problem in the future either. 😉

yegorich commented 7 years ago

I see it is already fixed in upstream. In Buildroot we had a 3.0.0 release where the files were just opened without using codecs. I'm closing this PR.