search

python-hyper / hyper

HTTP/2 for Python.
http://hyper.rtfd.org/en/latest/
MIT License
1.05k stars 191 forks source link

removing stream from recent_recv_streams on clean close #270

Closed nateprewitt closed 8 years ago

nateprewitt commented 8 years ago

This addresses #265. Not sure if the test is overkill for such a minor change, but I figured I'd err on the side of 101% coverage :) I'll strip it out if it's unneeded.

Lukasa commented 8 years ago

Thanks for this!

I'm happy with the change, and have no objection to that test, but I'd also like a more specific test. Can we write a test that cleanly closes one stream? That is, that uses a stream through its lifetime, such that it gets a complete response, and then confirms that it has been removed from everything?

nateprewitt commented 8 years ago

Were you looking for something more along the lines of this? This is what I originally wrote but felt it might exercise unnecessary code.

Lukasa commented 8 years ago

Yup @nateprewitt, that looks right.

nateprewitt commented 8 years ago

Replaced old test with lifecycle test. The former felt redundant with this one.

Lukasa commented 8 years ago

Fab, thanks @nateprewitt! :sparkles: :cake: :sparkles: