search

python-hyper / hyper

HTTP/2 for Python.
http://hyper.rtfd.org/en/latest/
MIT License
1.05k stars 192 forks source link

Send ping frame #273

Closed plucury closed 8 years ago

plucury commented 8 years ago

I'm using hyper to send messages to APNS, and it suggests checking the health of the connection with ping frame. However, I think it should be useful in other use cases.

Lukasa commented 8 years ago

Thanks for this! This change generally looks good to me, though I have left one inline note.

plucury commented 8 years ago

@Lukasa Thanks! Just updated my code.

Lukasa commented 8 years ago

Fab! I'm currently sat on a plane which means I can't effectively do the extra steps I like to do when I merge a PR, so if you don't mind I'll merge this a bit later in the day when I'm no longer awkwardly sat on an aircraft (or this flight might have wifi, in which case I'll do it here when this plane eventually takes off!)

plucury commented 8 years ago

@Lukasa That's fine. Have a nice trip!

Lukasa commented 8 years ago

Thanks @plucury! :sparkles: :cake: :sparkles: