python-hyper / hyper

HTTP/2 for Python.
http://hyper.rtfd.org/en/latest/
MIT License
1.05k stars 192 forks source link

Implement HTTP20Adapter.close to close connections #307

Open allanlei opened 7 years ago

allanlei commented 7 years ago

Fixes #306

allanlei commented 7 years ago

The http2bin.org endpoint seems to be down, is there another HTTP2 endpoint or a way to dummy the connection?

Lukasa commented 7 years ago

So I think @nateprewitt's deleted comment is right: I think we need to initiate a HTTP/2 request here. Rather than use http2bin you may need to write a socket-level test as is done elsewhere in the code.

nateprewitt commented 7 years ago

Not deleted, just hiding on the last "requested changes" comment thread 😉