search

python-hyper / hyper

HTTP/2 for Python.
http://hyper.rtfd.org/en/latest/
MIT License
1.05k stars 191 forks source link

Fix connection upgrade to work for both python2 and python3 #347

Closed ericdevries closed 7 years ago

ericdevries commented 7 years ago

I had an issue with this line of code not working in a python3 package, because the code in the h2 package differs between these 2 versions of python

Lukasa commented 7 years ago

@ericdevries I think you mis-identified the problem here. I think either your Python 3 or Python 2 environments are running an unsupported copy of h2: this code does not support h2 3.0 or higher, which is where this change would be needed.

ericdevries commented 7 years ago

What do you mean? h2 has to fix it or your code has to be made compatible with h2 version 3.0+?

Lukasa commented 7 years ago

Eventually hyper needs to be made compatible with h2 version 3.0, but for the moment our declared dependency versions exclude 3.0.