search

python-hyper / hyper

HTTP/2 for Python.
http://hyper.rtfd.org/en/latest/
MIT License
1.05k stars 191 forks source link

Fix: stream end when length of last chunk equal to MAX_CHUNK #356

Closed PrimozGodec closed 6 years ago

PrimozGodec commented 6 years ago

This pull request is fixing bug https://github.com/Lukasa/hyper/issues/355

I changed the approach of taking chunks form the generator, such that we know when we reach the last chunk with memorising the next chunk.

PrimozGodec commented 6 years ago

@Lukasa I changed the code and made unit test pass on my machine. I also added a test to test specific change. Sorry I can not find a change log. Can you tell me where is it? Also travis tests are failing it seems that they are failing because of some older code and not because of my changes.

matjazp commented 6 years ago

@PrimozGodec, CI is fixed now, can you rebase please?

Also, change log is in HISTORY.rst and CONTRIBUTORS.rst.

PrimozGodec commented 6 years ago

Thank you @matjazp. It is fixed now @Lukasa