search

python-hyper / hyper

HTTP/2 for Python.
http://hyper.rtfd.org/en/latest/
MIT License
1.05k stars 191 forks source link

Readtimeout is not implemented master #404

Open abhijeetgituser opened 5 years ago

abhijeetgituser commented 5 years ago

I am using hyper version hyper 0.7.0 and I am facing an issue with my code. I am not able to find out how readtimeout works hyper.

During execution I found that connect timeout is there but in case we are able to connect to the endpoint but never received any ACK messages back from the endpoint the connection hangs in between.

dhdavvie commented 5 years ago

What are you doing at the minute? This line seems to be where the read timeout for the socket is set, its value is set here. If timeout is a single value (passed in HTTP20Connection.__init__()), it uses that value for both connect_timeout and read_timeout, but if timeout is a tuple each value is used for the respective timeout.

abhijeetgituser commented 5 years ago

Thank you very much for the response.

I am installing hyper using pip. So I think I am getting master branch installed and changes/implementations(you suggest) are on the development branch. How can I get those changes installed using pip?

dhdavvie commented 5 years ago

The following should work: clone the repo locally, and check out the development branch, then run python setup.py install in the directory, that should install the package to your python packages. Note that it is a development branch so don't assume that everything works :)

abhijeetgituser commented 5 years ago

Last question, any plan to merge the changes in to the master in near future?

Thank you! you can close this issue

dhdavvie commented 5 years ago

That would be up to the repo owner, I'm just a passer by :) I can't close the issue unfortunately, you should be able to do that on your end