python-hyper / hyperlink

đź”— Immutable, Pythonic, correct URLs.
https://hyperlink.readthedocs.io/
Other
283 stars 41 forks source link

GitHub Actions CI #142

Closed twm closed 3 years ago

twm commented 3 years ago

Travis is queuing builds for ages.

I've also added Python 3.9 to CI and the package metadata. I notice that 2.6 isn't in CI. Should it still be listed as supported?

codecov[bot] commented 3 years ago

Codecov Report

Merging #142 (ddc04e1) into master (1949b07) will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #142   +/-   ##
=======================================
  Coverage   98.69%   98.69%           
=======================================
  Files          13       13           
  Lines        1840     1840           
  Branches      212      212           
=======================================
  Hits         1816     1816           
  Misses         12       12           
  Partials       12       12           

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 1949b07...ddc04e1. Read the comment docs.

wsanchez commented 3 years ago

Hrm, I think we should add 2.6 to the matrix. That does seem like an oversight… We bend over a bit to support 2.6 syntax, so it should be tested.

wsanchez commented 3 years ago

I'm not seeing the workflows running… is that because this is an external PR and not a branch?

twm commented 3 years ago

I honestly don't know. GHA is not great with the feedback... if you typo something in the YAML it doesn't tell you so it could be anything. I'll try creating a separate PR that's more obviously correct.

twm commented 3 years ago

Nothing seems to be happening on #143, so I guess I can't configure GHA from my fork.

wsanchez commented 3 years ago

@twm I'm getting ready for some travel this week but when I'm back in California, I can try making a branch with this and see if that works.

wsanchez commented 3 years ago

@twm I added you as an admin to the repo, so you should be able to make a branch with this diff if you can get to it before me.

twm commented 3 years ago

Thanks @wsanchez. I've recreated this PR over at #149. Closing this one in favor of that one, where GHA seems to be working.