search

python-hyper / wsproto

Sans-IO WebSocket protocol implementation
https://wsproto.readthedocs.io/
MIT License
266 stars 39 forks source link

Support HTTP/2 WebSockets #110

Closed pgjones closed 5 years ago

pgjones commented 5 years ago

This only includes helper functions for the handshake phase. This is because the HTTP/2 connection must be managed alongside the chosen I/O (in order for the flow control to work). The recommendation is to use the Hyper-h2 library with wsproto.

In order to support h2 client extension handshakes the handshake_extensions function has been renamed.

See #109 and #102 for previous discussion.

pgjones commented 5 years ago

@Kriechi Is your review approval still valid (since I reduced the scope a lot)?

Kriechi commented 5 years ago

I just reviewed it again - yes.

Please update the PR description as well.