search

python-hyper / wsproto

Sans-IO WebSocket protocol implementation
https://wsproto.readthedocs.io/
MIT License
261 stars 38 forks source link

Switch to a Github action for CI testing #138

Closed pgjones closed 4 years ago

pgjones commented 4 years ago

This is a basic initial version based on h11#89

pgjones commented 4 years ago

@Kriechi how does this look to you?

Kriechi commented 4 years ago

Shouldn't this already have triggered Github Actions on this PR?

pgjones commented 4 years ago

Shouldn't this already have triggered Github Actions on this PR?

I think it needs to be merged first, it has run here

Kriechi commented 4 years ago

Looks good overall.

Thoughts on having an explicit lint and docs job? Right now it is hard to find because it is part of the py38 job.

pgjones commented 4 years ago

Thoughts on having an explicit lint and docs job?

Yep, any idea how to share common steps between jobs?

pgjones commented 4 years ago

Having read a bit more, including Hynek's article on github actions I think it is best to start like this (rather than splitting the jobs). It is fairly clear if it fails in any way.