unify config structure with other python-hyper projects

python-hyper / wsproto

Sans-IO WebSocket protocol implementation

https://wsproto.readthedocs.io/

MIT License

261 stars 38 forks source link

unify config structure with other python-hyper projects #145

Closed Kriechi closed 4 years ago

Kriechi commented 4 years ago

This goes together with https://github.com/python-hyper/hyper-h2/pull/1228 and https://github.com/python-hyper/hyperframe/pull/146

pgjones commented 4 years ago

I think python projects are moving to src/package_name and we should do the same. I've done so following pallets (and tools such as poetry encouraging it).

Kriechi commented 4 years ago

I was expecting an argument about this 😄 My reasoning was this:

none of the other python-hyper org projects use a src/. And I personally don't have any projects that do either.
I haven't found any real recommendation or PEP or any other document explaining the benefits/differences/reasoning
and last but not least: I couldn't get code coverage working with the subfolder 😛

Kriechi commented 4 years ago

I've reverted the src/wsproto move to keep this PR a bit shorter. Let's continue the discussion after merging this.