python-hyper / wsproto

Sans-IO WebSocket protocol implementation
https://wsproto.readthedocs.io/
MIT License
261 stars 38 forks source link

Host not encoded with IDNA #160

Closed Kriechi closed 2 years ago

Kriechi commented 3 years ago

copied from https://github.com/mitmproxy/mitmproxy/issues/4622

We should IDNA-encode the Host header during the WS handshake in https://github.com/python-hyper/wsproto/blob/master/src/wsproto/handshake.py#L327

gndu91 commented 3 years ago

Is the latest change I made enough?

pgjones commented 2 years ago

Fixed by 2afeb33b4fd5bbc30d2c64b200a442f262a005ba