Handful of minor fixes - Githubissues

python-ivi / python-usbtmc

Provides a USBTMC driver for controlling instruments over USB

MIT License

162 stars 70 forks source link

Handful of minor fixes #21

Closed SimplicityGuy closed 8 years ago

SimplicityGuy commented 8 years ago

Minor refactoring of the kernel driver release
Indentation issue for an if/else
Bare minimal style changes (there are many more to do here to be pass pylint, pep8, flake8, etc, but this is a start)

SimplicityGuy commented 8 years ago

Any objections if I do a more extensive PEP8 cleanup?

alexforencich commented 8 years ago

Might as well.

SimplicityGuy commented 8 years ago

Ok, I'll get those done as a single PR. Additional features will be a separate PR.

alexforencich commented 8 years ago

What features are you thinking about adding?

SimplicityGuy commented 8 years ago

At the moment, none. As we get into using our instruments with python-usbtmc a bit more, we'll see. I have features in python-ivi to add more immediately (such as exposing a timeout property).

alexforencich commented 8 years ago

Gotcha. I am going to go through all of the pull requests over the next couple of weeks and figure out what can be merged and what needs to be modified. There was also one implementing Rigol quirks for usbtmc, I will have to see if I can get that one to apply.