search

python-jsonschema / check-jsonschema

A CLI and set of pre-commit hooks for jsonschema validation with built-in support for GitHub Workflows, Renovate, Azure Pipelines, and more!
https://check-jsonschema.readthedocs.io/en/stable
Other
214 stars 40 forks source link

Feature/add vendor bitbucket pipelines #282

Closed djgoku closed 1 year ago

sirosen commented 1 year ago

Hi, thanks for submitting this!

The CI issues aren't related to your work -- some dependency updates have put us in a bad state in which main fails CI right now. I'll try to make time in the next few days to fix this, and then we can get CI passing on this and merge it.

(In terms of your work here, no notes! It looks good. But I want the confirmation from CI that I'm not missing anything.)

djgoku commented 1 year ago

Thank you for the review!

Is there anything I can possibly help with?

sirosen commented 1 year ago

I appreciate the offer. In this case, I think you've already provided the most important thing, which is energy and attention put into the project! I've already put together a patch to get CI back in working shape and merged it (https://github.com/python-jsonschema/check-jsonschema/pull/284).

Would you be willing to rebase to pick up those fixes?

djgoku commented 1 year ago

Would you be willing to rebase to pick up those fixes?

Done!

sirosen commented 1 year ago

This should now be available in v0.23.3, and I've made sure to credit you in the changelog! :smile:

Please let me know if you see any issues with it.