search

python-jsonschema / check-jsonschema

A CLI and set of pre-commit hooks for jsonschema validation with built-in support for GitHub Workflows, Renovate, Azure Pipelines, and more!
https://check-jsonschema.readthedocs.io/en/stable
Other
206 stars 41 forks source link

Addition of CircleCI hook? #431

Closed jrdnbradford closed 3 months ago

jrdnbradford commented 4 months ago

Any interest in a CircleCI pre-commit hook? A schema exists at SchemaStore/schemastore and it seems to fit the other CI/CD-related hooks. I can put in a PR if interested.

sirosen commented 4 months ago

I'm always happy to add more hooks -- I'd gladly look at a PR! Because there are so many possible schemas and hooks to add, my general attitude has shifted to an "as requested" basis for adding them.

I'd eventually like to reposition this so that check-jsonschema derives most or all of its hooks from a data package with all of schemastore in it. I started on this as a possibility and some other folks did too, but there are some issues which need to be sorted out (correct licensing, automatic update and release process, and then managing reproducibility in pre-commit).