search

python-lsp / pylsp-mypy

Mypy plugin for the Python LSP Server.
MIT License
127 stars 35 forks source link

Add default mypy config file reference #20

Closed hirosassa closed 1 year ago

hirosassa commented 3 years ago

What is this PR?

This PR added the feature that pylsp-mypy refers mypy's default config files when there's no config file in the current project.

Reference: https://mypy.readthedocs.io/en/stable/config_file.html

hirosassa commented 3 years ago

@Richardk2n Hi! Cloud you please review this PR? This implementation looks working well in my local env. If I miss anything, please let me know. Thank you!

Richardk2n commented 3 years ago

How urgent is this? I'd like to change the config system somewhat and therefore would like to pay close attention when reviewing, therefore this might take some time. However I am currently writing my master thesis (will be finished in 1 to 1.5 month) and if you would agree, that this PR is not too urgent, i would review that afterwards.

hirosassa commented 3 years ago

I am currently writing my master thesis

Oh sorry, this is not urgent. Your thesis is more and more important than this PR. Please concentrate on it and I hope your defense go well 👍

Richardk2n commented 1 year ago

Sorry I left you hanging for so extremely long. I implemented this somewhat differently (to preserve search order). Does this implementation fulfill your needs?

hirosassa commented 1 year ago

@Richardk2n Thank you for your comment! I'll check it.

Richardk2n commented 1 year ago

Closing for housekeeping reasons. Should the changes not be sufficient, feel free to remind me.