Add support for error end locations - Githubissues

python-lsp / pylsp-mypy

Mypy plugin for the Python LSP Server.

MIT License

130 stars 37 forks source link

Add support for error end locations #61

Closed AntonVucinic closed 1 year ago

AntonVucinic commented 1 year ago

I just started using this plugin in neovim and noticed that errors weren't underlined properly. After a quick look at the source code it seems as this is a simple and easy fix:

instead of the --show-column-numbers option use --show-error-end option
modify the line_pattern regex
modify the parse_line function with correct diagnostic end location
remove the comment on line 100 :)

link to mypy doc explaining the --show-error-end option

If you give me the green light I am willing to make a PR by myself.

Richardk2n commented 1 year ago

Sure go ahead. This requires mypy v0.981 or above, feel free to set that as a dependency.