search

python-lsp / python-lsp-server

Fork of the python-language-server project, maintained by the Spyder IDE team and the community
MIT License
1.91k stars 196 forks source link

Support for workspace symbols #237

Open jgarte opened 2 years ago

jgarte commented 2 years ago

I ask because I tried using this package and it complained that pylsp does not support this feature. It worked well with pyright though.

Does pyright support symbols and pylsp not?

ccordoba12 commented 2 years ago

Correct, Pylsp doesn't support workspace symbols, sorry.

jgarte commented 2 years ago

Is there any plans to implement it?

@ccordoba12

What's you approach to workspace symbols? Do you prefer not to use this feature?

ccordoba12 commented 2 years ago

There are no plans right now, sorry.

Maybe Jedi offers this functionality but we haven't checked because there has been little interest for it.

astoff commented 2 years ago

For the record, I find the workspace symbols feature quite useful. One can always grep the project for def something, but that's not as handy. It would also seem relatively straightforward to implement, which gives it a pretty good cost/benefit ratio.

ccordoba12 commented 2 years ago

It seems this is supported by Jedi, so it's feasible here. However, we're swamped with other things, so I don't know when we'll have time to implement it.

tristone13th commented 2 years ago

In the README I saw you mentioned that Jedi can provide this function, so does it mean we can use it well now?

ccordoba12 commented 2 years ago

No, we need to implement that functionality in the way expected by the LSP protocol here.

jgarte commented 2 years ago

No, we need to implement that functionality in the way expected by the LSP protocol here.

@ccordoba12 Thanks for clarifying that for us.

eyalk11 commented 9 months ago

Made a pull request to resolve it. https://github.com/python-lsp/python-lsp-server/pull/511