search

python-lsp / python-lsp-server

Fork of the python-language-server project, maintained by the Spyder IDE team and the community
MIT License
1.96k stars 195 forks source link

Justify configuration settings that override (built-in) plugin configuration settings #294

Open doolio opened 2 years ago

doolio commented 2 years ago

For example:

pylsp.plugins.flake8.exclude has a default value of [] which overrides the flake8 default .svn,CVS,.bzr,.hg,.git,__pycache__,.tox,.nox,.eggs,*.egg.

pylsp.plugins.pycodestyle.exclude has a default value of [] which overrides the pycodestyle default .svn,CVS,.bzr,.hg,.git. pylsp.plugins.pycodestyle.filename has a default value of [] which overrides the pycodestyle default *.py. pylsp.plugins.pycodestyle.ignore has a default value of [] which overrides the pycodestyle default which I believe is E121,E123,E126,E133,E226,E241,E242,E704,W503,W504,W505

If in fact we don't wish to override the underlying plugin default then I believe pylsp should set its default values to null.

doolio commented 1 year ago

Any thoughts on this?

ccordoba12 commented 1 year ago

If in fact we don't wish to override the underlying plugin default then I believe pylsp should set its default values to null.

I'm ok with this change. Please submit a PR for it.