search

python-lsp / python-lsp-server

Fork of the python-language-server project, maintained by the Spyder IDE team and the community
MIT License
1.91k stars 196 forks source link

Black format Repo #407

Closed tkrabel-db closed 1 year ago

tkrabel-db commented 1 year ago

What is changed in that PR?

Addresses #392, i.e. this PR auto formats the whole repo using black to see the diff.

black is arguably the most popular formatter out there.

What needs to be changed further?

Some black re-formattings violate pylint and pycodestyle, e.g.

pycodestyle

test/test_text_edit.py:27:9: W503 line break before binary operator
test/test_text_edit.py:42:9: W503 line break before binary operator
test/test_text_edit.py:64:9: W503 line break before binary operator
test/test_text_edit.py:107:9: W503 line break before binary operator
test/test_text_edit.py:128:9: W503 line break before binary operator
test/test_text_edit.py:150:9: W503 line break before binary operator
test/test_text_edit.py:172:9: W503 line break before binary operator
test/test_text_edit.py:194:9: W503 line break before binary operator
test/test_text_edit.py:216:9: W503 line break before binary operator
test/test_text_edit.py:302:9: W503 line break before binary operator
test/test_workspace.py:320:13: W503 line break before binary operator
test/test_workspace.py:322:9: W503 line break before binary operator
test/test_workspace.py:371:13: W503 line break before binary operator
test/test_workspace.py:373:9: W503 line break before binary operator
test/test_workspace.py:416:13: W503 line break before binary operator
test/test_workspace.py:418:9: W503 line break before binary operator
test/plugins/test_autopep8_format.py:85:9: W503 line break before binary operator
test/plugins/test_yapf_format.py:67:9: W503 line break before binary operator
test/plugins/test_yapf_format.py:78:9: W503 line break before binary operator

pylint pylsp

************* Module test.test_workspace
test/test_workspace.py:240:0: W1404: Implicit string concatenation found in call (implicit-str-concat)
test/test_workspace.py:259:0: W1404: Implicit string concatenation found in call (implicit-str-concat)
************* Module pylsp.plugins.pylint_lint
pylsp/plugins/pylint_lint.py:292:12: R1732: Consider using 'with' for resource-allocating operations (consider-using-with)
pylsp/plugins/pylint_lint.py:294:0: I0021: Useless suppression of 'consider-using-with' (useless-suppression)
************* Module pylsp.plugins.rope_autoimport
pylsp/plugins/rope_autoimport.py:33:0: R0911: Too many return statements (7/6) (too-many-return-statements)
pylsp/plugins/rope_autoimport.py:35:0: I0021: Useless suppression of 'too-many-return-statements' (useless-suppression)
ccordoba12 commented 1 year ago

Thanks a lot for your help with this @tkrabel-db! Could you resume your work after PR #389 is merged? Thanks!

tkrabel-db commented 1 year ago

I close this an open a new PR, since solving the merge conflicts is messy and I don't want to cause a regression