search

python-lsp / python-lsp-server

Fork of the python-language-server project, maintained by the Spyder IDE team and the community
MIT License
1.76k stars 186 forks source link

Add support for pyflakes 3.1 and pycodestyle 2.11 #415

Closed yan12125 closed 11 months ago

yan12125 commented 11 months ago

ContinueInFinally is dropped in pyflakes 3.1 [1].

flake8 is bumped to a version that supports pyflakes 3.1 [2].

Closes https://github.com/python-lsp/python-lsp-server/issues/412

[1] https://github.com/PyCQA/pyflakes/pull/752 [2] https://flake8.pycqa.org/en/latest/release-notes/6.1.0.html

yan12125 commented 11 months ago

Forgot to mention - the lower bound for pyflakes is bumped to 3.1.0 as flake8 6.1.0 already requires that version, as described in flake8 release notes.

yan12125 commented 11 months ago

Good point, thanks!

ERROR: Could not find a version that satisfies the requirement flake8<7,>=6.1.0; extra == "all" (from python-lsp-server[all,test]) (from versions: 0.1, 0.2, 0.3, 0.4, 0.5, 0.6, 0.7, 0.8, 0.9, 1.0, 1.1, 1.2, 1.3, 1.3.1, 1.4, 1.5, 1.6, 1.6.1, 1.6.2, 1.7.0, 2.0, 2.1.0, 2.2.0, 2.2.1, 2.2.2, 2.2.3, 2.2.4, 2.2.5, 2.3.0, 2.4.0, 2.4.1, 2.5.0, 2.5.1, 2.5.2, 2.5.3, 2.5.4, 2.5.5, 2.6.0, 2.6.1, 2.6.2, 3.0.0b1, 3.0.0b2, 3.0.0, 3.0.1, 3.0.2.dev0, 3.0.2.dev1, 3.0.2, 3.0.3, 3.0.4, 3.1.0, 3.1.1, 3.2.0, 3.2.1, 3.3.0.dev0, 3.3.0, 3.4.0, 3.4.1, 3.5.0, 3.6.0, 3.7.0, 3.7.1, 3.7.2, 3.7.3, 3.7.4, 3.7.5, 3.7.6, 3.7.7, 3.7.8, 3.7.9, 3.8.0a1, 3.8.0a2, 3.8.0, 3.8.1, 3.8.2, 3.8.3, 3.8.4, 3.9.0, 3.9.1, 3.9.2, 4.0.0, 4.0.1, 5.0.0, 5.0.1, 5.0.2, 5.0.3, 5.0.4)

(https://github.com/python-lsp/python-lsp-server/actions/runs/5839448515/job/15843654307)

New flake8 requires Python 3.8 [1]. Is it better to drop Python 3.7 from python-lsp-server or install older dependencies for older Python?

[1] https://flake8.pycqa.org/en/latest/release-notes/6.0.0.html

ccordoba12 commented 11 months ago

New flake8 requires Python 3.8 [1]. Is it better to drop Python 3.7 from python-lsp-server

Right. I already did that in pull request #417. So, please rebase your pull request or merge with the latest master to get the changes. Then, your pull request should pass.

yan12125 commented 11 months ago

Right. I already did that in pull request https://github.com/python-lsp/python-lsp-server/pull/417. So, please rebase your pull request or merge with the latest master to get the changes. Then, your pull request should pass.

Thank you! Rebased and squashed.