Closed tkrabel-db closed 1 year ago
Fixes #392, i.e. this PR auto formats the whole repo using black to see the diff.
black
black is arguably the most popular formatter out there.
Some black re-formattings violate pylint and pycodestyle, e.g.
pylint
pycodestyle
# All errors are of this form test/test_text_edit.py:27:9: W503 line break before binary operator ...
pylint pylsp
************* Module test.test_workspace test/test_workspace.py:240:0: W1404: Implicit string concatenation found in call (implicit-str-concat) test/test_workspace.py:259:0: W1404: Implicit string concatenation found in call (implicit-str-concat) ************* Module pylsp.plugins.pylint_lint pylsp/plugins/pylint_lint.py:292:12: R1732: Consider using 'with' for resource-allocating operations (consider-using-with) pylsp/plugins/pylint_lint.py:294:0: I0021: Useless suppression of 'consider-using-with' (useless-suppression) ************* Module pylsp.plugins.rope_autoimport pylsp/plugins/rope_autoimport.py:33:0: R0911: Too many return statements (7/6) (too-many-return-statements) pylsp/plugins/rope_autoimport.py:35:0: I0021: Useless suppression of 'too-many-return-statements' (useless-suppression)
What is changed in that PR?
Fixes #392, i.e. this PR auto formats the whole repo using
black
to see the diff.black is arguably the most popular formatter out there.
What needs to be changed further?
Some black re-formattings violate
pylint
andpycodestyle
, e.g.pycodestyle
pylint pylsp
My suggestion:
black
takes care of code styling, so we can removepycodestyle
altogether.pylint
goes deeper, as it also e.g. cares about import order, so I suggest the user needs to fix these manually