search

python-lsp / python-lsp-server

Fork of the python-language-server project, maintained by the Spyder IDE team and the community
MIT License
1.76k stars 186 forks source link

rewrite multihop GTD with single jedi API call once jedi supports it #446

Open smacke opened 9 months ago

smacke commented 9 months ago

Ref: discussion in https://github.com/python-lsp/python-lsp-server/pull/443

tkrabel-db commented 9 months ago

@ccordoba12 @krassowski can you please close this?

In general, we should keep the issue section clean. Happy to do it if you give me the according rights! :)

krassowski commented 9 months ago

This issue was opened because after discussion with the Jedi author the conclusion was that:

  1. The workaround proposed in #443 is not ideal (among others performance-wise)
  2. The change should happen in Jedi itself

As the philosophy of pylsp is to upstream as much as possible, I believe this should be ultimately implemented in Jedi and then the workaround that was merged should be removed. This issue tracks removal of the workaround. As such I do not see a reason to close it.

tkrabel-db commented 9 months ago

Ah, thanks for the clarification. My bad!