Make workspace/didChangeConfig work with notebook documents

python-lsp / python-lsp-server

Fork of the python-language-server project, maintained by the Spyder IDE team and the community

MIT License

1.91k stars 196 forks source link

Make workspace/didChangeConfig work with notebook documents #462

Closed tkrabel-db closed 11 months ago

tkrabel-db commented 11 months ago

What change is proposed?

Notebook doesn't support update_config, as configuration is handled on the cell level. This makes workspace/didChangeConfguration error when there are notebook documents in the workspace. This PR fixes that.

How is this tested?

[x] unit test
[x] Manually on Databricks notebooks, which supports notebookDocument messages

tkrabel-db commented 11 months ago

@ccordoba12 @rchl this is ready for review

tkrabel-db commented 11 months ago

@ccordoba12 I addressed the comments. Thanks for the swift feedback!