Closed tkrabel-db closed 11 months ago
It's weird. Unrelated tests are failing ...
Tests are reaching the timeout:
Indeed 7 minutes for pytest here seems suspicious, but there is a small chance it could be GitHub temporarily throttling for no good reason.
@krassowski I see why the test takes so long.
In any case, I do think the config should look more like
def pylsp_settings() -> Dict[str, Dict[str, Dict[str, Any]]]:
# Default rope_completion to disabled
return {
"plugins": {
"rope_autoimport": {
"enabled": False, # global "kill switch"
"memory": False,
"completions": {
"enabled": True,
},
"code_actions": {
"enabled": True,
},
}
}
}
I will address this tomorrow. Need some sleep now :)
Couldn't resist @ccordoba12 @krassowski . I think my PR is ready to review now :)
@krassowski, would you like to give this one another pass? Or should I merge?
Fixes #403
Testing