Add support for notebook document completions

python-lsp / python-lsp-server

Fork of the python-language-server project, maintained by the Spyder IDE team and the community

MIT License

1.75k stars 186 forks source link

Add support for notebook document completions #486

Closed smacke closed 6 months ago

smacke commented 7 months ago

In this PR, we add support for notebook document completions, so that completions can work across cell boundaries. The implementation is straightforward and closely follows that for definitions.

Test plan: added a unit test that fails without the changes in this PR and passes with the changes.

tkrabel commented 6 months ago

@ccordoba12 can you TAL at this PR? :)

ccordoba12 commented 6 months ago

Thanks for the ping @tkrabel! Will do right away.

smacke commented 6 months ago

Awesome TY!