Closed carandraug closed 5 years ago
Me and Toshiki got a working implementation for the Mirao52-e mirror which Ian has already tested. See my wip-mirao52e
branch. If no one has any issues with it, I will merge it soon.
This mirror has a limitation on the valid patterns. The sum of the absolute values of the pattern (after scaling to the [-1 1] range) must not be above 24. I don't think there's anything we can do about it other than error, and the client must be aware that it's possible for a pattern to be invalid. Maybe we can document this in the parent class?
Pushed and closed.
We got a Mirao52e mirror from Engineering that we want to support.