search

python-microscope / microscope

Python library for control of microscope devices, supporting hardware triggers and distribution of devices over the network for performance and flexibility.
https://www.python-microscope.org
GNU General Public License v3.0
69 stars 41 forks source link

Clarity and LinkamStage do not implement required abstract methods #113

Closed iandobbie closed 4 years ago

iandobbie commented 4 years ago

David's latest updates have broken the Clarity device. On startup it generates an error:

TypeError: Can't instantiate abstract class Clarity with abstract methods _on_shutdown, initialize

carandraug commented 4 years ago

The mentioned changes that broke the Clarity is commit 83f1256cdfa1 . Seems like our ABCs never worked in Python 3. That change fixed it so all devices that didn't implement the Device abstract methods are now failing like they should. I went now through the devices and seems to me that the LinkamStage also does not implement the initialize and _on_shutdown methods.

carandraug commented 4 years ago

I have now fixed the issue for the LinkamStage in c0a70733301f . I went through the other classes and seems like they all have the required methods. Closing as fixed.