Preparing for refactor of Settings.

python-microscope / microscope

Python library for control of microscope devices, supporting hardware triggers and distribution of devices over the network for performance and flexibility.

https://www.python-microscope.org

GNU General Public License v3.0

69 stars 41 forks source link

Preparing for refactor of Settings. #125

Closed mickp closed 4 years ago

mickp commented 4 years ago

Managing different types of Settings may be achieved more flexibly and simply through the use of subclasses of Setting and the use of a factory pattern or helper method for their creation.

Added TODO
Replaced direct instantiation of Settings with creation through method.

carandraug commented 4 years ago

Pushed after also making the Device.settings attribute private. This effectively makes the Device.*_setting methods the only sanctioned methods to manipulate settings which should give us all flexibility to make changes how settings work internally.