search

python-microscope / microscope

Python library for control of microscope devices, supporting hardware triggers and distribution of devices over the network for performance and flexibility.
https://www.python-microscope.org
GNU General Public License v3.0
69 stars 41 forks source link

121 augmentor implementation #133

Open mickp opened 4 years ago

mickp commented 4 years ago

Needs testing with hardware

An alternative implementation for #121, replacing #124.

The camera is augmented with methods to do data processing and return the correct image shape depending on processing mode. Camera parameters are passed as a dict, to avoid the dot-notation problem discussed in #124.

mickp commented 4 years ago

@NickHallONBI - can you test this with the hardware when you get a chance?

iandobbie commented 4 years ago

Testing today on the cryo Aurox setup appears to work.

One problem is the docstring..

Config sample: device(microscope.filterwheels.aurox.Clarity, {'camera': 'microscope.Cameras.cameramodule.SomeCamera', 'camera.someSetting': value})

The camera module is a python object not a string so shouldn't be in quotes.

carandraug commented 3 years ago

I started looking into this and merge into master but then noticed that while we import ClarityProcessor we then call clarity_process.ClarityProcessor. So has this actually been tested? What really have people been running?

iandobbie commented 3 years ago

Exactly my question. We should merge what works and close the other issues.