python-microscope / microscope

Python library for control of microscope devices, supporting hardware triggers and distribution of devices over the network for performance and flexibility.
https://www.python-microscope.org
GNU General Public License v3.0
67 stars 39 forks source link

replace laser power with fraction of intensity #155

Closed carandraug closed 3 years ago

carandraug commented 4 years ago

A laser device has multiple methods to set the power all based in mw. However, we want them to replace them with percentage (see cockpit/#641) basically because it would be simpler and more useful.

carandraug commented 4 years ago

Proposal fix on my 155-no-laser-mw branch. This is backwards incompatible (it removes all LaserDevice.*_power_mw methods and replaces them with a power property with a value in the [0, 1] range.

Given the current situation, this has not been tested with hardware.

carandraug commented 3 years ago

No opposition, so I merged the proposed change.