search

python-microscope / microscope

Python library for control of microscope devices, supporting hardware triggers and distribution of devices over the network for performance and flexibility.
https://www.python-microscope.org
GNU General Public License v3.0
67 stars 39 forks source link

Implementing Shuttering mode and fixing OBIS laser #157

Closed juliomateoslangerak closed 1 year ago

juliomateoslangerak commented 4 years ago

This PR is implementing a getShutteringMode function for the cameras. See cockpit issue https://github.com/MicronOxford/cockpit/issues/651

It also fixes the OBIS laser

NB Please ignore the changes in the deepstar laser. I don't know how to remove those from the PR

iandobbie commented 1 year ago

This is also adding your config files to the main repository. I think we need to redo the pull request from a clean master and just pull in the obis changes. Is the electronic shutter anything like the issues that Danny was talking about with doing software triggering for light sources? If so we should integrate the solutions so they work for everyone.

juliomateoslangerak commented 1 year ago

Yes. I think at the time I did this I was a bit more messy with my git. I will isolate the relevant commits and post them here or in the relevant issues. I don't think is the same issue Danny mentioned. Meanwhile I call this electronic shuttering mode. The thing is to have, in microscope, the means to get whether a camera is doing global or rolling shutter. On the cockpit side I need this information to adapt the sync of the laser so that it just triggers when all the pixels are exposed.

iandobbie commented 1 year ago

Ok. I understand better what you are doing. As you suggest this is separate from the trigger issues that Danny is trying to rectify.

However we should probably document this together with the other trigger changes, so we have a easy reference to keep the behaviour consistent.

juliomateoslangerak commented 1 year ago

Closing this PR