search

python-microscope / microscope

Python library for control of microscope devices, supporting hardware triggers and distribution of devices over the network for performance and flexibility.
https://www.python-microscope.org
GNU General Public License v3.0
67 stars 39 forks source link

Aurox module should be a controller, not a filter wheel. #164

Open iandobbie opened 3 years ago

iandobbie commented 3 years ago

The Aurox module although it mostly looks like a filter wheel also has thew camera processing pipeline so it is not a simple filter wheel. We should move it into controllers section.

carandraug commented 3 years ago

The aurox module at the moment is only a filterwheel. There are two PRs that propose making it a controller but neither has been merged yet. But even then, as discussed on those PRs, making it a controller was a hack to get some sort of composite device, and that is not desirable.

Let's delay this until #121 is solved and we decide on the actual implementation (but if the module path is based on implementation details then we already have a problem, so maybe this is indicative that this wouldn't go into controllers even if we decide to use a controller).