python-microscope / microscope

Python library for control of microscope devices, supporting hardware triggers and distribution of devices over the network for performance and flexibility.
https://www.python-microscope.org
GNU General Public License v3.0
67 stars 39 forks source link

Lumencor Light Engine TCP support #189

Open dstoychev opened 3 years ago

dstoychev commented 3 years ago

This one is a really low-hanging fruit, as pyserial already allows to use TCP. Besides a small change to how TCP commands are sent and received (no termination required), the main change is that instead of using the serial.Serial class directly, instances should be created with the serial.serial_for_url() function instead. This way, the user can specify any protocol and it will just work. For TCP, instead of COM port or device path, a URL needs to be used: socket://192.168.201.200:8095.

carandraug commented 3 years ago

The use case behind doing this the user is already using the ethernet interface to have the web interface.

dstoychev commented 2 years ago

Implemented here: https://github.com/dstoychev/microscope/tree/lumencor-le.