search

python-microscope / microscope

Python library for control of microscope devices, supporting hardware triggers and distribution of devices over the network for performance and flexibility.
https://www.python-microscope.org
GNU General Public License v3.0
73 stars 42 forks source link

CoolLED out of date #190

Open dstoychev opened 3 years ago

dstoychev commented 3 years ago

The CoolLED implementation seems out of date. It doesn't use the new trigger mixins, and it implements enable/disable methods directly instead of using _do_enable and _do_disable. There may be other issues as well. I think it needs to be reviewed and brought up-to-date.

carandraug commented 3 years ago

You're right that it implements enable and disable instead of _do_enable and _do_disable, but it does implement the TriggerTargetMixin. Are you sure you're looking at the latest master branch? This was done in 3d69829abc919