search

python-microscope / microscope

Python library for control of microscope devices, supporting hardware triggers and distribution of devices over the network for performance and flexibility.
https://www.python-microscope.org
GNU General Public License v3.0
73 stars 42 forks source link

Mac log files are put in the wrong place. #191

Open iandobbie opened 3 years ago

iandobbie commented 3 years ago

The log files on the mac go in the current dir which is not the expected place and breaks if the system is running in a sandbox from a double clickable icon. I have a suggested fix in my branch mac-log-dir

carandraug commented 3 years ago

Why is it not the expected place? If we are changing the location of the log files to something system specific, this should be done for all platforms, not only for mac.

The proposed fix has two issues:

  1. it only changes the location of the individual device server while leaving the __MAIN__.log file still in the current working directory.
  2. it saves the log files in the cockpit logs directory but this is not cockpit

I believe the real reason behind this issue is not that it was a surprise to find the log files in "~/Library" but instead that it was preventing to work in the installer sandbox. A command line option to control the location of the logs file would also solve your problem and would also solve the current monkey patching we currently have to do on the testsuite to test the device server without creating the log files.

Since we already have logs in stderr by default, I propose that we just don't have log files unless some directory for log files is set on the command line.

iandobbie commented 3 years ago

David Miguel Susano Pinto notifications@github.com writes:

Why is it not the expected place? If we are changing the location of the log files to something system specific, this should be done for all platforms, not only for mac.

The proposed fix has two issues:

1 it only changes the location of the individual device server while leaving the MAIN.log file still in the current working directory. 2 it saves the log files in the cockpit logs directory but this is not cockpit

Yes, I noticed that and was just about to fix that.

I believe the real reason behind this issue is not that it was a surprise to find the log files in "~/Library" but instead that it was preventing to work in the installer sandbox. A command line option

Yes the sandbox is the killer, but there is a spec for log files on mac so maybe we should follow that by default if no dir specified.

to control the location of the logs file would also solve your problem and would also solve the current monkey patching we currently have to do on the testsuite to test the device server without creating the log files.

Since we already have logs in stderr by default, I propose that we just don't have log files unless some directory for log files is set on the command line.

Ok. to be honest the simulation logs are probably totally useless unless you are debugging something very strange.

Ian