python-microscope / microscope

Python library for control of microscope devices, supporting hardware triggers and distribution of devices over the network for performance and flexibility.
https://www.python-microscope.org
GNU General Public License v3.0
66 stars 38 forks source link

Ludl stage dies with unhelpful error if not connected. #255

Closed iandobbie closed 1 year ago

iandobbie commented 1 year ago

The ludl stage control code dies at line 159 if the return buffer is empty as there is no stage connected there. Maybe the cable fell out or the stage is not powered. Need a better error check to return a sensible error.

iandobbie commented 1 year ago

Turns out now I have the ludl stage running under cockpit there are a few issues.

1) bad error on startup as described above

2) stage size and position isnt properly returned after search for limits at stage startup.

iandobbie commented 1 year ago

The stage size issue is actually a cockpit problem. The stage doesn't know its limits until it has moved to them, but cockpit adds the axis to the positioner list before the limits are returned. Need to think about how best to solve this.

iandobbie commented 1 year ago

Fixed the error on startup if not connected in 48c330b Will close and add a new issue for the stag size issue.