get/set of binning and roi should be accepting instances of Roi and Binning

python-microscope / microscope

Python library for control of microscope devices, supporting hardware triggers and distribution of devices over the network for performance and flexibility.

https://www.python-microscope.org

GNU General Public License v3.0

70 stars 41 forks source link

get/set of binning and roi should be accepting instances of Roi and Binning #86

Closed carandraug closed 5 years ago

carandraug commented 5 years ago

The methods get_binning and get_roi (as well as their setters) make use of lists of ints. However, we now have a Roi and Binning class which should be used across all the cameras.

mickp commented 5 years ago

Applied in #90.

carandraug commented 5 years ago

Fixed now that pull request #90 has been merged.