python-microscopy / pyme-plugin

Template for making plug-ins for the Python-Microscopy Environment (PYME)
http://www.python-microscopy.org/
BSD 2-Clause "Simplified" License
3 stars 2 forks source link

Is setup.py supposed to be up a level? #11

Closed zacsimile closed 3 years ago

zacsimile commented 3 years ago

From the way it calls install_plugin.py, I think it's supposed to be up a level.

barentine commented 3 years ago

yeah I probably didn't get that right when I added it in #3, mostly copying what I had in a plugin which came before #2

Alternative would be to remove the extra PACKAGE_NAME in the path which would make it even easier to use right?

mind PRing if you're testing it @zacsimile ?

zacsimile commented 3 years ago

It seems to work up a level and I personally think it makes more sense to include setup.py in the root and install_plugin.py within the plugin directory (PYME, for example, has setup.py in the python-microscopy top level directory). I'll PR.