Added command `create-config` (#169)

python-microservices / pyms

Library of utils to create REST Python Microservices

https://python-microservices.github.io/home/

GNU General Public License v3.0

265 stars 45 forks source link

Added command `create-config` (#169) #204

Closed himanshus-dev closed 3 years ago

himanshus-dev commented 3 years ago

Added command functionality
Added tests for command
Added methods to dump, remove config file NOTE: The command by default, doesn't create/overwrite if a config file already exists.

Fixes #169

Changes proposed in this PR:

Added yaml config generator command

coveralls commented 3 years ago

Pull Request Test Coverage Report for Build 1068

76 of 79 (96.2%) changed or added relevant lines in 6 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage decreased (-0.1%) to 99.012%

Changes Missing Coverage	Covered Lines	Changed/Added Lines	%
pyms/config/conf.py	23	26	88.46%
<!--	Total:	76	79	96.2%	-->

Totals
Change from base Build 1066:	-0.1%
Covered Lines:	1905
Relevant Lines:	1924

💛 - Coveralls

alexppg commented 3 years ago

@path2himanshu the coverage has decreased, can you increase it or level it with how it was?

avara1986 commented 3 years ago

@path2himanshu the coverage has decreased, can you increase it or level it with how it was?

And fix the linters :stuck_out_tongue:

himanshus-dev commented 3 years ago

@alexppg the test coverage is back to normal now. @avara1986 The linter breaking the build is will require to change the Command.initfunction to a major extent as the error is that function is too complex or we can make flake8 ignore it.

himanshus-dev commented 3 years ago

@avara1986 Please review

avara1986 commented 3 years ago

thanks for the PR @path2himanshu! I test it manually and works very well :smile: but the PR need more tests, specially in the pyms/config/conf.py file :+1: