python-microservices / pyms

Library of utils to create REST Python Microservices
https://python-microservices.github.io/home/
GNU General Public License v3.0
265 stars 45 forks source link

Could we add Google Cloud KMS encryption #228

Closed jeffny2015 closed 3 years ago

jeffny2015 commented 3 years ago

Is your feature request related to a problem? Please describe. A clear and concise description of what the problem is. Ex. I'm always frustrated when [...]

Describe the solution you'd like A clear and concise description of what you want to happen.

Describe alternatives you've considered A clear and concise description of any alternative solutions or features you've considered.

Additional context Add any other context or screenshots about the feature request here.

i see documentation say it supports but i dont see it implemented

alexppg commented 3 years ago

Where do you see it? In the docs it only talks about AWS's KMS, as far as I can see: https://python-microservices.github.io/encrypt_decryt_configuration/#2-encrypt-with-kms

jeffny2015 commented 3 years ago

image

jeffny2015 commented 3 years ago

You can move this file to a Kubernetes secret, use Vault or encrypt the configuration with AWS KMS or Google KMS. We strongly recommend these way of encrypting/decrypting your configuration, but if you don't want a vendor locking option or you don't have the resources to use these methods, we provide a way to encrypt and decrypt your variables.

jeffny2015 commented 3 years ago

i mean, could you add it ?

avara1986 commented 3 years ago

We add this paragraph as recommendations and best practices to store configuration. In the nexts blocks describe the implementations that exists in PyMS. On the other hand, it could be confusing. We update this section, thanks @jeffny2015 for your contribution :)

alexppg commented 3 years ago

My bad, I didn't see it.