search

python-needle / needle

Automated tests for your CSS.
https://needle.readthedocs.io/
Other
590 stars 50 forks source link

Support for Selenium 3 #55

Closed sterago closed 7 years ago

sterago commented 7 years ago

setup.py defines a requirement for selenium <3 Are there any plans to remove this restriction?

jphalip commented 7 years ago

I see no reason for keeping this restriction. However, first one needs to check that needle's code is compatible or to provide the required code updates to make it compatible both with Selenium 2 & 3. Have you tested it with Selenium 3 yet?

sterago commented 7 years ago

Yes, I did some basic tests using a fresh virtualenv with needle==0.3 and selenium==3.0.1 and I didn't see any problems

jphalip commented 7 years ago

Ok thanks. Could you submit a pull request with changes to setup.py and .travis.yml so we can check that all tests pass?

sterago commented 7 years ago

sure thing

jphalip commented 7 years ago

Fixed in #56

benpatterson commented 7 years ago

We are also impacted by the <3 requirement; thank you for the fix!

I'm wondering if the changes will be bundled and released soon? Willing to put in a cycle to make that happen if you are short on time... Cheers.

jphalip commented 7 years ago

@benpatterson Thanks for the reminder, I've just pushed a new release.

benpatterson commented 7 years ago

Awesome; thank you @jphalip !