python-needle / needle

Automated tests for your CSS.
https://needle.readthedocs.io/
Other
590 stars 50 forks source link

Updates and testing for Chrome and Firefox #63

Closed jmbowman closed 7 years ago

jmbowman commented 7 years ago

This resolves some errors I was getting with recent versions of Firefox and geckodriver, and also addresses #60 .

jphalip commented 7 years ago

This is great, thank you. Would you mind just breaking this up in separate logical commits?

jmbowman commented 7 years ago

Sure, looks like it's going to take a little while to fix up the Travis configuration anyway. I was really trying to fix just one thing (get screenshots working with the latest Firefox), but then had to do the rest just to get tests passing...I'll start with those things I had to fix along the way first. I'll keep this PR open for a while to test the overall Travis outcomes, if you don't mind.

jphalip commented 7 years ago

Sure, that's fine. You can also try setting up your own Travis project for more flexibility running the builds.

jmbowman commented 7 years ago

This code was split up into #64 and #65 .