python-needle / needle

Automated tests for your CSS.
https://needle.readthedocs.io/
Other
590 stars 50 forks source link

Test fails with cryptic error message if fresh image is larger then baseline image (imagemagick) #75

Open moellering opened 6 years ago

moellering commented 6 years ago

Expected Output

assertSameFiles Needle should either state that the images are similar or that they are not.

Actual Output

ValueError: ("could not convert string to float: b'idt'") thrown at /needle/engines/imagemagick_engine.py:24

Reproduce

  1. create an images 1.png and 2.png where 2.png is bigger then 1.png
  2. run magick compare -metric RMSE -dissimilarity-threshold 1.0 -subimage-search 1.png 2.png d.png
  3. get compare: width or height exceeds limit '1.png' @ error/cache.c/OpenPixelCache/3491.

Suggestions

We could order the images by size. However I guess that will not fix the problem is one image is wider but not as high as the other one.

Contribution

I tried to run the tests but many fail on my system. I'm not sure if that is a problem with the tests or with me not using the right commands. I created an issue #74 If this issue is solved I'd be happy to implement my the reordering of the images.

akoidan commented 4 years ago

Any progress? It's been 1.5 year already...