python-openapi / openapi-schema-validator

OpenAPI schema validator is a Python library that validates schema against OpenAPI Schema Specification v3.0 and v3.1
BSD 3-Clause "New" or "Revised" License
101 stars 31 forks source link

Support for scientific notation #146

Open redparham opened 12 months ago

redparham commented 12 months ago

This schema with scientific notation maximum: 1e2

openapi: 3.0.3
info:
  title: scientific notation
  description: ...
  version: 1.0.0
paths:
  /pet:
    put:
      tags:
        - pet
      summary: ...
      description: ...
      operationId: updatePet
      requestBody:
        description: ...
        content:
          application/json:
            schema:
              $ref: '#/components/schemas/Pet'
      responses:
        '200':
          description: Successful operation
components:
  schemas:
    Pet:
      type: object
      properties:
        id:
          type: integer
          format: int64
          maximum: 1e2
          example: 10

results in this unexpected failure

# Validation Error

{'description': '...', 'content': {'application/json': {'schema': {'type': 'object', 'properties': {'id': {'type': 'integer', 'format': 'int64', 'maximum': '1e2', 'example': 10}}}}}} is not valid under any of the given schemas

Failed validating 'oneOf' in schema['properties']['paths']['patternProperties']['^\\/']['patternProperties']['^(get|put|post|delete|options|head|patch|trace)$']['properties']['requestBody']:
    {'oneOf': [{'$ref': '#/definitions/RequestBody'},
               {'$ref': '#/definitions/Reference'}]}

On instance['paths']['/pet']['put']['requestBody']:
    {'content': {'application/json': {'schema': {'properties': {'id': {'example': 10,
                                                                       'format': 'int64',
                                                                       'maximum': '1e2',
                                                                       'type': 'integer'}},
                                                 'type': 'object'}}},
     'description': '...'}

# Due to one of those errors

## {'type': 'object', 'properties': {'id': {'type': 'integer', 'format': 'int64', 'maximum': '1e2', 'example': 10}}} is not valid under any of the given schemas

Failed validating 'oneOf' in schema[0]['properties']['content']['additionalProperties']['properties']['schema']:
    {'oneOf': [{'$ref': '#/definitions/Schema'},
               {'$ref': '#/definitions/Reference'}]}

On instance['content']['application/json']['schema']:
    {'properties': {'id': {'example': 10,
                           'format': 'int64',
                           'maximum': '1e2',
                           'type': 'integer'}},
     'type': 'object'}

## '$ref' is a required property

Failed validating 'required' in schema[1]:
    {'patternProperties': {'^\\$ref$': {'format': 'uri-reference',
                                        'type': 'string'}},
     'required': ['$ref'],
     'type': 'object'}

On instance:
    {'content': {'application/json': {'schema': {'properties': {'id': {'example': 10,
                                                                       'format': 'int64',
                                                                       'maximum': '1e2',
                                                                       'type': 'integer'}},
                                                 'type': 'object'}}},
     'description': '...'}
...

If I change maximum: 1e2 to maximum: 100, it validates without error.

p1c2u commented 12 months ago

Hi @redparham

you use OpenAPI 3.0.3 (Wright Draft 00 schema) which doesn't support integers as floats. Switch to OpenAPI 3.1 (Draft 2020-12 schema) and it should work for you.

redparham commented 12 months ago

Hi @p1c2u.

I see this in the 3.0.1 and 3.1.0 spec:

Note that integer as a type is also supported and is defined as a JSON number without a fraction or exponent part. https://spec.openapis.org/oas/v3.1.0#data-types

p1c2u commented 12 months ago

Hmm , that's true. I will investigate this more.