search

python-openapi / openapi-spec-validator

OpenAPI Spec Validator is a CLI, pre-commit hook and python package that validates OpenAPI Specs against the OpenAPI 2.0 (aka Swagger), OpenAPI 3.0 and OpenAPI 3.1 specification.
Apache License 2.0
337 stars 62 forks source link

Include tests in sdist archives #199

Closed mgorny closed 1 year ago

mgorny commented 1 year ago

Include the "tests" directory in sdist archives, to permit Linux distributions to use these archives instead of GitHub snapshots that are not reliable long-term.

codecov[bot] commented 1 year ago

Codecov Report

Merging #199 (fb1bb55) into master (91f5cf2) will not change coverage. The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #199   +/-   ##
=======================================
  Coverage   92.60%   92.60%           
=======================================
  Files          13       13           
  Lines         433      433           
  Branches       64       64           
=======================================
  Hits          401      401           
  Misses         22       22           
  Partials       10       10

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

p1c2u commented 1 year ago

@mgorny that's a good idea, thanks for the contribution

mgorny commented 1 year ago

Thank you! Should I open PRs for other openapi repositories or can you handle it from here?

p1c2u commented 1 year ago

@mgorny if that's the only change needs to be done to make it work then I can handle this

mgorny commented 1 year ago

@mgorny if that's the only change needs to be done to make it work then I can handle this

I think so, unless tests require extra files to run. In any case, I'll test them on the next release and submit a PR if anything else is needed. Thanks a lot!