search

python-organizers / conferences

List of Python Conferences around the World
187 stars 90 forks source link

Autoformat CSV files #180

Closed jonafato closed 3 months ago

jonafato commented 1 year ago

Autoformat CSV files to ensure that

This branch also applies the formatting to the existing CSV files, which resulted in some rows being resorted to match the sorting intent that has been followed in most changes.

This change is not yet complete. I'd like to include a GitHub Actions task that runs this formatter on PRs and commits the changes back, which will require GitHub App authentication in order to allow the automated commits to trigger other GHA workflows.

jonafato commented 3 months ago

It looks like this has broken something and should be reverted until it can be fixed. I thought I opened this as a draft PR, but if it was marked ready to review / merge, that was my fault. GitHub can be weird about pushing commits from CI and allowing validators to still run, so this may need to be debugged from that configuration standpoint.

invisibleroads commented 3 months ago

I was able to get this working by separating the pull request validation from the commit push formatting (see https://github.com/invisibleroads/github-actions-experiments).

Thanks so much for the original github action workflows. It took some getting used to but I think I understand it now. Sorry about the workflow failed notifications spam.

Hope you're well.