search

python-pillow / Pillow

Python Imaging Library (Fork)
https://python-pillow.org
Other
12.32k stars 2.23k forks source link

Change harfbuzz versions in wheels #8421

Closed radarhere closed 1 month ago

radarhere commented 1 month ago

Two changes here.

  1. As noted in #8361, harfbuzz has switched to meson - https://github.com/harfbuzz/harfbuzz/releases/tag/9.0.0.

More specifically though, it now requires meson >= 0.55.

This is a problem, as the base image for oss-fuzz uses Ubuntu 20.04, which only has meson 0.53.2

So this PR downgrades harfuzz on OSS Fuzz to the version before meson became mandatory. I've used the environment variable 'SANITIZER' to detect OSS Fuzz.

  1. I found that harfbuzz 8.5.0 was being installed on macOS. I've fixed that, and 10.0.1 is now installed instead.
hugovk commented 1 month ago

Here's an issue about upgrading Ubuntu in the base image: https://github.com/google/oss-fuzz/issues/11835

khaledhosny commented 1 month ago

You can pip install meson on oss-fuzz build scripts, that is how we build HarfBuzz there (you might also want to bin meson version to a known working one, since new meson versions sometimes break build, at least in the past).

radarhere commented 1 month ago

Thanks for the suggestion! I've created https://github.com/python-pillow/Pillow/pull/8424